[rear-devel] [rear/rear] 397cb5: Update 400_save_directories.sh

Johannes Meixner noreply at github.com
Wed May 12 12:08:06 CEST 2021


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 397cb555259b165cf6764a881d3b6c7f1a017bc0
      https://github.com/rear/rear/commit/397cb555259b165cf6764a881d3b6c7f1a017bc0
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-05-07 (Fri, 07 May 2021)

  Changed paths:
    M usr/share/rear/prep/default/400_save_directories.sh

  Log Message:
  -----------
  Update 400_save_directories.sh

In prep/default/400_save_directories.sh
also exclude mountpoints that are below mountpoints of "type autofs"
because automounted NFS filesystems can cause this script to hang up if NFS server fails
because then the 'stat' command may wait indefinitely for the NFS server to respond,
see https://github.com/rear/rear/issues/2610


  Commit: b8e050d543b984a5fe7376e9d4d884ffb109f43c
      https://github.com/rear/rear/commit/b8e050d543b984a5fe7376e9d4d884ffb109f43c
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M usr/share/rear/prep/default/400_save_directories.sh

  Log Message:
  -----------
  Update 400_save_directories.sh

Using findmnt option '-T' but not '-M' which is not supported
on Fedora based distributions at least not on RHEL 7.9
cf. https://github.com/rear/rear/pull/2613#pullrequestreview-654678482


  Commit: bff29dfe2b02b840a0643d75764d187e2d293f83
      https://github.com/rear/rear/commit/bff29dfe2b02b840a0643d75764d187e2d293f83
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M usr/share/rear/prep/default/400_save_directories.sh

  Log Message:
  -----------
  Update 400_save_directories.sh

Explain why mountpoints below mountpoints of "type autofs" should be also excluded.


  Commit: 75cae46a7eada78e44a91a2b481f2e065a43e964
      https://github.com/rear/rear/commit/75cae46a7eada78e44a91a2b481f2e065a43e964
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M usr/share/rear/prep/default/400_save_directories.sh

  Log Message:
  -----------
  Update 400_save_directories.sh

Fixed detection when a directory is already listed in the directories_permissions_owner_group file:
Before it was: grep "^$directory" "$directories_permissions_owner_group_file" 1>&2
Now it is: grep -q "^$directory " "$directories_permissions_owner_group_file"
The crucial change is the added trailing space in "^$directory " that avoids
e.g. '/foo' is found when only '/foobar ...' is already listed in that file.
Fortunarely the directories in FHSdirectories are properly sorted
so that things worked well by luck.


  Commit: 3a6993968852791a63fac49bce6e81d52e258622
      https://github.com/rear/rear/commit/3a6993968852791a63fac49bce6e81d52e258622
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-05-12 (Wed, 12 May 2021)

  Changed paths:
    M usr/share/rear/prep/default/400_save_directories.sh

  Log Message:
  -----------
  Merge pull request #2613 from rear/jsmeix-also-exclude-below-autofs

In prep/default/400_save_directories.sh
also exclude mountpoints that are below mountpoints of "type autofs":
Those are below an ancestor mountpoint that is owned/created by the automounter.
It is possible to create a sub-mountpoint below an automounted mountpoint
but the fact that the sub-mountpoint is not local means it should be excluded
(i.e. there is no need to recreate the non-local sub-mountpoint directory),
see https://github.com/rear/rear/issues/2610


Compare: https://github.com/rear/rear/compare/c6500f9c42f1...3a6993968852


More information about the rear-devel mailing list