[rear-devel] [rear/rear] ae3bb0: #2596 Mark unused LVM PV devices in comment in dis...

Johannes Meixner noreply at github.com
Tue May 4 13:09:16 CEST 2021


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: ae3bb06e73dd6d8e3a11aa11fe060a1b10619825
      https://github.com/rear/rear/commit/ae3bb06e73dd6d8e3a11aa11fe060a1b10619825
  Author: Gratien D'haese <gratien.dhaese at gmail.com>
  Date:   2021-04-21 (Wed, 21 Apr 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  #2596 Mark unused LVM PV devices in comment in disklayout.conf file

Signed-off-by: Gratien D'haese <gratien.dhaese at gmail.com>


  Commit: b86467797cfc45ca676e7720f0b91086b417e4c6
      https://github.com/rear/rear/commit/b86467797cfc45ca676e7720f0b91086b417e4c6
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Update 220_lvm_layout.sh

Reorgainzed the error checking logic to keep error checking sufficiently complete.
In particular still error out when "PV device '$pdev' is empty or more than one word".
Additional DebugPrint when "Skipping PV $pdev that is not part of a valid VG"
and more exact wording in user messages regarding what was actually tested.


  Commit: b4713b32e826a5c550a7c01249ce71327263094c
      https://github.com/rear/rear/commit/b4713b32e826a5c550a7c01249ce71327263094c
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Update 220_lvm_layout.sh

Much simpler and more straightforward code (KISS).
In particular check abort condition first and error out directly there.


  Commit: 3e355a17598b7aa207251194b6301f8c52eb705e
      https://github.com/rear/rear/commit/3e355a17598b7aa207251194b6301f8c52eb705e
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Update 220_lvm_layout.sh

Typo fix "cannot to make" -> "cannot make"


  Commit: 24420768523bb5d3e4403555388c626fe1cbf5df
      https://github.com/rear/rear/commit/24420768523bb5d3e4403555388c626fe1cbf5df
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2021-04-23 (Fri, 23 Apr 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Update 220_lvm_layout.sh

Added missing comments that explain why the code is as is and added
the iusse URL https://github.com/rear/rear/issues/2596 to explain why
PVs that are not part of a VG are documented as comment in disklayout.conf


  Commit: ec7fb6d3be135601ea0a72989a167d6f5cf82595
      https://github.com/rear/rear/commit/ec7fb6d3be135601ea0a72989a167d6f5cf82595
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-05-04 (Tue, 04 May 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Merge pull request #2603 from gdha/master

Have unused LVM PV devices only as comment in disklayout.conf:
PVs that are not part of a VG are documented as comment in disklayout.conf
but they are not recreated because they were not used on the original system
so there is no need to recreate them by "rear recover"
see https://github.com/rear/rear/issues/2596


Compare: https://github.com/rear/rear/compare/7b1354d6f3be...ec7fb6d3be13


More information about the rear-devel mailing list