[rear-devel] [rear/rear] 8b4652: Completely overhauled USB filesystem kernel module...

Johannes Meixner noreply at github.com
Thu Dec 10 11:54:56 CET 2020


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 8b46526adc7d43369ffab8e4856aeb477c397187
      https://github.com/rear/rear/commit/8b46526adc7d43369ffab8e4856aeb477c397187
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M usr/share/rear/prep/USB/default/380_copy_usb_fs_module.sh

  Log Message:
  -----------
  Completely overhauled USB filesystem kernel module handling

Completely overhauled USB filesystem related kernel module handling:
In prep/USB/default/380_copy_usb_fs_module.sh do no longer unconditionally
add the USB filesystem to the MODULES and MODULES_LOAD arrays
because there are systems where the USB filesystem (e.g. 'ext3')
is no kernel module (e.g. on openSUSE Leap 15.2) and then via
MODULES_LOAD "modprobe ext3" fails with a scaring false alarm
"modprobe: FATAL: ... ext3 not found in directory /lib/modules/..."
error message from 40-start-udev-or-load-modules.sh that appears
on the user's terminal during recovery system startup.


  Commit: 678714a1022e9269036c83455f08cff243684d9a
      https://github.com/rear/rear/commit/678714a1022e9269036c83455f08cff243684d9a
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M usr/share/rear/skel/default/etc/scripts/system-setup.d/40-start-udev-or-load-modules.sh

  Log Message:
  -----------
  Update 40-start-udev-or-load-modules.sh

Tell when "Loading modules specified in /etc/modules"
so the user can make sense of where possible modprobe error messages belong


  Commit: 49a6d07234c76e6776074ee45b5a439389d542a7
      https://github.com/rear/rear/commit/49a6d07234c76e6776074ee45b5a439389d542a7
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M usr/sbin/rear

  Log Message:
  -----------
  Update rear

Introduce DEBUG_OUTPUT_DEV in sbin/rear
(same kind as DISPENSABLE_OUTPUT_DEV)
so that it is now possible to have program output in the log
only in debug modes in particular when that program output
might needlessly alert the user like error messages when they appear
in non-debug modes without additional debug information that make it clear
where the messages belong to and whether or not there is actually a problem.
For a usage example see in prep/USB/default/380_copy_usb_fs_module.sh
"if modinfo "$usb_fs" 1>/dev/null 2>>/dev/$DEBUG_OUTPUT_DEV ; then ..."
where modinfo stderr could be like "modinfo: ERROR: Module ... not found"
which is not at all an error here because here 'modinfo' is used to only find out
if something is available as kernel module so failures are an expected behaviour.


  Commit: 8082144856fb0b02b4685cfb035bb0a660b77d68
      https://github.com/rear/rear/commit/8082144856fb0b02b4685cfb035bb0a660b77d68
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2020-12-10 (Thu, 10 Dec 2020)

  Changed paths:
    M usr/sbin/rear
    M usr/share/rear/prep/USB/default/380_copy_usb_fs_module.sh
    M usr/share/rear/skel/default/etc/scripts/system-setup.d/40-start-udev-or-load-modules.sh

  Log Message:
  -----------
  Merge pull request #2537 from rear/jsmeix-USB-filesystem-module

Completely overhauled USB filesystem kernel module handling:
In prep/USB/default/380_copy_usb_fs_module.sh do no longer unconditionally
add the USB filesystem to the MODULES and MODULES_LOAD arrays
because there are systems where the USB filesystem (e.g. 'ext3')
is no kernel module and then (via MODULES_LOAD and /etc/modules)
"modprobe ext3" would fail in 40-start-udev-or-load-modules.sh
with a false alarm "modprobe: FATAL: ... ext3 not found ..." message
that would appear on the user's terminal during recovery system startup.


Compare: https://github.com/rear/rear/compare/8f2273df1f66...8082144856fb


More information about the rear-devel mailing list