[rear-devel] [rear/rear] f517c1: Have MODULES all_modules by default plus needed ad...

Johannes Meixner noreply at github.com
Thu Mar 7 13:29:29 CET 2019


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: f517c1ad7effb093c7b6908592ac6647e60e5d51
      https://github.com/rear/rear/commit/f517c1ad7effb093c7b6908592ac6647e60e5d51
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-03-06 (Wed, 06 Mar 2019)

  Changed paths:
    M usr/share/rear/build/GNU/Linux/400_copy_modules.sh
    M usr/share/rear/conf/GNU/Linux.conf
    M usr/share/rear/conf/default.conf

  Log Message:
  -----------
  Have MODULES all_modules by default plus needed adaptions for that


  Commit: 2b2ca1adeede11875cadadba2a1e374c9e524803
      https://github.com/rear/rear/commit/2b2ca1adeede11875cadadba2a1e374c9e524803
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2019-03-07 (Thu, 07 Mar 2019)

  Changed paths:
    M usr/share/rear/build/GNU/Linux/400_copy_modules.sh
    M usr/share/rear/conf/GNU/Linux.conf
    M usr/share/rear/conf/default.conf

  Log Message:
  -----------
  Merge pull request #2069 from jsmeix/have_MODULES_all_modules_by_default_issue_2041

Now there is in default.conf MODULES=( 'all_modules' )
which means that now by default all kernel modules
get included in the recovery system,
see https://github.com/rear/rear/issues/2041
Usually this is required when migrating to different hardware.
Additionaly it makes the recovery system better prepared
when this or that additional kernel module is needed, e.g.
to ensure a USB keyboard is usable in the recovery system,
see https://github.com/rear/rear/issues/1870
or to ensure data on external medium (e.g. iso9660) can be read,
see https://github.com/rear/rear/issues/1202
Furthermore this is helpful to be on the safe side against possibly
missing dependant kernel modules that are not automatically found,
see https://github.com/rear/rear/issues/1355
The drawback of MODULES=( 'all_modules' ) is that it makes the
recovery system (and its ISO image) somewhat bigger,
see https://github.com/rear/rear/issues/2041 for some numbers.
With MODULES=() the old behaviour can be still specified.
There is a minor backward incompatible change:
Before the user had to specify in local.conf
MODULES=( "${MODULES[@]}" 'moduleX' 'moduleY' )
to get some specific modules included in addition to the ones
via an empty MODULES=() but now the user must specify
MODULES=( 'moduleX' 'moduleY' )
for that because with "${MODULES[@]}"
the new default value 'all_modules' would be kept which
would trigger that all modules get included so that now
MODULES=( "${MODULES[@]}" 'moduleX' 'moduleY' )
includes all kernel modules in the recovery system
which includes in particular 'moduleX' and 'moduleY'
so that things still work but with a bigger recovery system.
For details see the MODULES description in default.conf.


Compare: https://github.com/rear/rear/compare/75f239acce39...2b2ca1adeede


More information about the rear-devel mailing list