[rear-devel] [rear/rear] 666d4e: Remove code unused since commit 2301a925ac06400cd1...

pcahyna noreply at github.com
Thu Oct 14 18:36:03 CEST 2021


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 666d4e6b91afe1ce5a2d7eb810f5686e43578572
      https://github.com/rear/rear/commit/666d4e6b91afe1ce5a2d7eb810f5686e43578572
  Author: Pavel Cahyna <pcahyna at redhat.com>
  Date:   2021-10-04 (Mon, 04 Oct 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/100_include_partition_code.sh

  Log Message:
  -----------
  Remove code unused since commit 2301a925ac06400cd17093dcbd947ec7802037cf


  Commit: 1cfe44dfdcc8c63f4a29c12260f03c8a7a2f60f8
      https://github.com/rear/rear/commit/1cfe44dfdcc8c63f4a29c12260f03c8a7a2f60f8
  Author: Pavel Cahyna <pcahyna at redhat.com>
  Date:   2021-10-04 (Mon, 04 Oct 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/110_include_lvm_code.sh

  Log Message:
  -----------
  Do not use global variables in diskrestore.sh

Fix a problem introduced in commits
b184194f37dd22a7e55655ff388579297239e73c and
311bfb3da1d5e47a2ff144123a2457e634f67893 (PR #1806) that shows up when
there are multiple VGs to restore.

Using variables create_thin_volumes_only and create_logical_volumes to
propagate information from VG creation to LV creation does not work well
in the case of multiple VGs, because the variables are global and if
there are multiple VGs, their values will leak from one VG to another.
The generated diskrestore.sh script does not guarantee that the LVs of a
given VG are created immediately after their VG and before creating
another VG. Currently, the script first creates all VGs and then all LVs,
so all the LVs in all VGs will see the value of create_logical_volumes
and create_thin_volumes_only from the last VG, not from their own. This
matters when different VGs behave differently (typically if one has a
thin pool and the other does not).

Fix by replacing the scalar values by arrays of VG names. If a given VG
is in the array, it is the equivalent of the former scalar value being 1
for the given VG, if it is not in the array, it is an equivalent of a
former value of 0.

For the create_volume_group variable the change is not needed, but do it
nevertheless for symmetry with other variables.


  Commit: d5267358bbf86357bc922c6ab590814a3bd0b9af
      https://github.com/rear/rear/commit/d5267358bbf86357bc922c6ab590814a3bd0b9af
  Author: Pavel Cahyna <pcahyna at redhat.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/110_include_lvm_code.sh

  Log Message:
  -----------
  Explain the purpose of lists in layout script


  Commit: 990e47e245ab4f2d255401b89c2c19d42762853b
      https://github.com/rear/rear/commit/990e47e245ab4f2d255401b89c2c19d42762853b
  Author: Pavel Cahyna <pcahyna at redhat.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/100_include_partition_code.sh
    M usr/share/rear/layout/prepare/GNU/Linux/110_include_lvm_code.sh

  Log Message:
  -----------
  Eliminate some calls to deprecated BugIfError


  Commit: 9967e26b8a9ca371deb949f7ee8f6c9b1f58b25e
      https://github.com/rear/rear/commit/9967e26b8a9ca371deb949f7ee8f6c9b1f58b25e
  Author: Pavel Cahyna <pcahyna at redhat.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/100_include_partition_code.sh

  Log Message:
  -----------
  Move a check for block device to the layout script

After this change, nothing in 100_include_partition_code.sh requires the
actual hardware anymore - only the saved layout. This enables running
the script outside of the rescue environment for testing, if one has
the saved layout data, and thus facilitates testing and experimenting a
lot.

Functional change: if the disk is not found, it is now the layout script
that aborts with BugError, not whole ReaR.


  Commit: db673c43316c444cd5b2bc0eed92fa028d9a017d
      https://github.com/rear/rear/commit/db673c43316c444cd5b2bc0eed92fa028d9a017d
  Author: pcahyna <pcahyna at users.noreply.github.com>
  Date:   2021-10-14 (Thu, 14 Oct 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/100_include_partition_code.sh
    M usr/share/rear/layout/prepare/GNU/Linux/110_include_lvm_code.sh

  Log Message:
  -----------
  Merge pull request #2691 from pcahyna/fix-multiple-vg-recreation

Fix multiple VG recreation

See https://github.com/rmetrich/rear/commit/b184194f37dd22a7e55655ff388579297239e73c#r56498696 and https://github.com/rmetrich/rear/commit/311bfb3da1d5e47a2ff144123a2457e634f67893#r56498755 for the description of the problem.


Compare: https://github.com/rear/rear/compare/d0be11304e4e...db673c43316c


More information about the rear-devel mailing list