[rear-devel] [rear/rear] 62592d: Overhauled RAID code

Johannes Meixner noreply at github.com
Mon Nov 29 14:58:04 CET 2021


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 62592da15108f355363c2749501cbda0a9a90e53
      https://github.com/rear/rear/commit/62592da15108f355363c2749501cbda0a9a90e53
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-16 (Tue, 16 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/210_raid_layout.sh

  Log Message:
  -----------
  Overhauled RAID code

Overhauled layout/save/GNU/Linux/210_raid_layout.sh
based on https://github.com/rear/rear/pull/2702
i.e. with the changes in https://github.com/rear/rear/pull/2702


  Commit: dc20466f3185aed08b71174e75a43c81cfae5587
      https://github.com/rear/rear/commit/dc20466f3185aed08b71174e75a43c81cfae5587
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-18 (Thu, 18 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/210_raid_layout.sh

  Log Message:
  -----------
  Update 210_raid_layout.sh

Completely overhauled layout/save/GNU/Linux/210_raid_layout.sh
- no longer a subshell that appends all stdout to disklayout.conf
but explicit append to disklayout.conf where needed
to be safe against accidental things written to disklayout.conf
- handle each mdadm option in one place i.e. parse and prepare output
- handle options ordered by importance, mandatory first, then optional ones
- basic tests that mandatory options are syntactically valid plus Error if not


  Commit: 64a5ce55b82b31b7ec6b2f2a1093ae7d4e10685d
      https://github.com/rear/rear/commit/64a5ce55b82b31b7ec6b2f2a1093ae7d4e10685d
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/120_include_raid_code.sh

  Log Message:
  -----------
  Update 120_include_raid_code.sh

Overhauled layout/prepare/GNU/Linux/120_include_raid_code.sh


  Commit: e980b65154c67b82bb69b1ca874fbbb01e102dc1
      https://github.com/rear/rear/commit/e980b65154c67b82bb69b1ca874fbbb01e102dc1
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/210_raid_layout.sh

  Log Message:
  -----------
  Update 210_raid_layout.sh

Use COMMAND | while read ... do ... done
instead of while read ... do ... done < <( COMMAND )


  Commit: d87c5f397437b5be1f48add567e83441db0fdf6a
      https://github.com/rear/rear/commit/d87c5f397437b5be1f48add567e83441db0fdf6a
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/120_include_raid_code.sh

  Log Message:
  -----------
  Update 120_include_raid_code.sh

Fixed mdadm version handling code


  Commit: 8472f4bc9a7034ac237ff48cdaa44f4abd0b3cfb
      https://github.com/rear/rear/commit/8472f4bc9a7034ac237ff48cdaa44f4abd0b3cfb
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-24 (Wed, 24 Nov 2021)

  Changed paths:
    A usr/share/rear/layout/recreate/default/220_verify_layout.sh

  Log Message:
  -----------
  Create 220_verify_layout.sh

New layout/recreate/default/220_verify_layout.sh
Verify RAID devices are actually recreated with the UUIDs in disklayout.conf
because mdadm silently ignores this option when creating IMSM arrays
(both containers and the volumes inside them) and picks a random UUID
cf. https://github.com/rear/rear/pull/2702#issuecomment-970395567


  Commit: 19bd86decadb88b785782adc922cd2a20a660e0c
      https://github.com/rear/rear/commit/19bd86decadb88b785782adc922cd2a20a660e0c
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-25 (Thu, 25 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh

  Log Message:
  -----------
  Update 120_confirm_wipedisk_disks.sh

Support user specified DISKS_TO_BE_WIPED (i.e. final power to the user)
to mitigate https://github.com/rear/rear/issues/2715


  Commit: cd382493ce8ac0fdacdb2b363d504f3c909a9795
      https://github.com/rear/rear/commit/cd382493ce8ac0fdacdb2b363d504f3c909a9795
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-25 (Thu, 25 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/150_wipe_disks.sh

  Log Message:
  -----------
  Update 150_wipe_disks.sh

Support user specified DISKS_TO_BE_WIPED (i.e. final power to the user)
to mitigate https://github.com/rear/rear/issues/2715


  Commit: 470714aba12bb59620ed43e39f903cf2ca14c9bd
      https://github.com/rear/rear/commit/470714aba12bb59620ed43e39f903cf2ca14c9bd
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-25 (Thu, 25 Nov 2021)

  Changed paths:
    M doc/user-guide/06-layout-configuration.adoc

  Log Message:
  -----------
  Update 06-layout-configuration.adoc

Document current disk layout file syntax for 'raid' entries according to
what https://github.com/rear/rear/pull/2714 results.


  Commit: 0cb21299efea81900285a8f224e0a0c6a20160e5
      https://github.com/rear/rear/commit/0cb21299efea81900285a8f224e0a0c6a20160e5
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M usr/share/rear/conf/default.conf

  Log Message:
  -----------
  Update default.conf

In default.conf describe how user specified DISKS_TO_BE_WIPED works.


  Commit: 5e8f10222f548990d1f4dcf13943ffb6f476f121
      https://github.com/rear/rear/commit/5e8f10222f548990d1f4dcf13943ffb6f476f121
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/prepare/GNU/Linux/120_include_raid_code.sh

  Log Message:
  -----------
  Update 120_include_raid_code.sh

In layout/prepare/GNU/Linux/120_include_raid_code.sh
the FEATURE_MDADM_UUID code is meanwhile obsolete because
all mdadm versions in supported ReaR Linux distributions support --uuid
cf. https://github.com/rear/rear/pull/2714#issuecomment-973938852
and https://github.com/rear/rear/pull/2714#issuecomment-979989656


  Commit: bc2eb6985bedb858ac2705522b815a0523c087bc
      https://github.com/rear/rear/commit/bc2eb6985bedb858ac2705522b815a0523c087bc
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-29 (Mon, 29 Nov 2021)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/210_raid_layout.sh

  Log Message:
  -----------
  Update 210_raid_layout.sh

Show disk layout 'raid' entry format/syntax as comment in disklayout.conf
cf. same kind of code in layout/save/GNU/Linux/200_partition_layout.sh


  Commit: fea67a386ca9a1b0ab2843146fc6fb9c192ae3fc
      https://github.com/rear/rear/commit/fea67a386ca9a1b0ab2843146fc6fb9c192ae3fc
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-11-29 (Mon, 29 Nov 2021)

  Changed paths:
    M doc/user-guide/06-layout-configuration.adoc
    M usr/share/rear/conf/default.conf
    M usr/share/rear/layout/prepare/GNU/Linux/120_include_raid_code.sh
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh
    M usr/share/rear/layout/recreate/default/150_wipe_disks.sh
    A usr/share/rear/layout/recreate/default/220_verify_layout.sh
    M usr/share/rear/layout/save/GNU/Linux/210_raid_layout.sh

  Log Message:
  -----------
  Merge pull request #2714 from rear/jsmeix-RAID-overhauled

Overhauled RAID code
based on https://github.com/rear/rear/pull/2702
that is about initial software RAID IMSM support
i.e. with the changes in that pull request:
Completely overhauled layout/save/GNU/Linux/210_raid_layout.sh
- no longer a subshell that appends all stdout to disklayout.conf
but explicit append to disklayout.conf where needed
to be safe against accidental things written to disklayout.conf
- handle each mdadm option in one place i.e. parse and prepare output
- handle options ordered by importance, mandatory first, then optional ones
- basic tests that mandatory options are syntactically valid plus Error if not.
Overhauled layout/prepare/GNU/Linux/120_include_raid_code.sh
- the FEATURE_MDADM_UUID code is meanwhile obsolete because
all mdadm versions in supported ReaR Linux distributions support '--uuid'.
New layout/recreate/default/220_verify_layout.sh
to verify if RAID devices are recreated with the UUIDs in disklayout.conf
because mdadm silently ignores this option when creating IMSM arrays
(both containers and the volumes inside them) and picks a random UUID
cf. https://github.com/rear/rear/pull/2702#issuecomment-970395567
Support user specified DISKS_TO_BE_WIPED to mitigate
https://github.com/rear/rear/issues/2715
see the DISKS_TO_BE_WIPED description in default.conf


Compare: https://github.com/rear/rear/compare/66cef0c8efef...fea67a386ca9


More information about the rear-devel mailing list