[rear-devel] [rear/rear] f1a61f: Improved wiping disks

Johannes Meixner noreply at github.com
Tue Dec 7 16:24:23 CET 2021


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: f1a61f771f4e55d35b7ca503718d4b49ff8ba083
      https://github.com/rear/rear/commit/f1a61f771f4e55d35b7ca503718d4b49ff8ba083
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-01 (Wed, 01 Dec 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh

  Log Message:
  -----------
  Improved wiping disks

In layout/recreate/default/120_confirm_wipedisk_disks.sh
skip disks that do not exist on the bare hardware in the recovery system
and exclude disks that are write-protected and
show what disks will be wiped in any case to the user.
In layout/recreate/default/150_wipe_disks.sh do no longer
open (and close) LUKS volumes because encrypted volumes
contain meaningless data unless opened and unencrypted so there is no need
to wipe anything inside an encrypted LUKS container, cf. "Regarding LUKS"
in https://github.com/rear/rear/pull/2514#issuecomment-743483945


  Commit: 6d6ef62a4080590b60bc4f09d370fb4fd53f5255
      https://github.com/rear/rear/commit/6d6ef62a4080590b60bc4f09d370fb4fd53f5255
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-01 (Wed, 01 Dec 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/150_wipe_disks.sh

  Log Message:
  -----------
  Update 150_wipe_disks.sh


  Commit: 74de0966a5f21fb41531e9d4711932b6df83856a
      https://github.com/rear/rear/commit/74de0966a5f21fb41531e9d4711932b6df83856a
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M usr/share/rear/conf/default.conf

  Log Message:
  -----------
  Update default.conf

The default USER_INPUT_INTERRUPT_TIMEOUT is now 10 seconds
to give the user a better chance to recognize an automated input
and be able to actually hit a key to interrupt.


  Commit: 08a3d457e54e2916141f95fe2ab18371e7fd0111
      https://github.com/rear/rear/commit/08a3d457e54e2916141f95fe2ab18371e7fd0111
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh

  Log Message:
  -----------
  Update 120_confirm_wipedisk_disks.sh

For wiping RAID devices that do not (yet) exist in the recovery system
automatically determine their parent disks and wipe them (if found).


  Commit: 14c88d9705f36240c529379df5753dcd4789bfc9
      https://github.com/rear/rear/commit/14c88d9705f36240c529379df5753dcd4789bfc9
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-03 (Fri, 03 Dec 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh

  Log Message:
  -----------
  Update 120_confirm_wipedisk_disks.sh

In layout/recreate/default/120_confirm_wipedisk_disks.sh
when there is no PKNAME for disks we use KNAME (so the parent of a disk is the disk itself)
and we also use KNAME as fallback when lsblk does not support PKNAME and proceed bona fide
so we wipe only KNAME of a partition but not its parent disk when PKNAME is not supported.
No longer misuse USER_INPUT_WIPE_DISKS_CONFIRMATION which is meant to be set only by the user
but set an appropriate timeout for the the user confirmation dialog which is simpler and more straightforward.


  Commit: 2a65a7d98755b507f025d86e3c98d5b394e415a5
      https://github.com/rear/rear/commit/2a65a7d98755b507f025d86e3c98d5b394e415a5
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-03 (Fri, 03 Dec 2021)

  Changed paths:
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh

  Log Message:
  -----------
  Update 120_confirm_wipedisk_disks.sh

More explanatory comments how things behave when parent_device is
not as usual a disk but in the KNAME fallback case where it could be a partition.


  Commit: 60467ceea0ee1a90e27c9cb99468aad2a044a823
      https://github.com/rear/rear/commit/60467ceea0ee1a90e27c9cb99468aad2a044a823
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-07 (Tue, 07 Dec 2021)

  Changed paths:
    M usr/share/rear/conf/default.conf

  Log Message:
  -----------
  Update default.conf

In default.conf describe protection via WRITE_PROTECTED_IDS
for disks in DISKS_TO_BE_WIPED


  Commit: cc3bc3793602ef44cd93a452b60be16cee65446c
      https://github.com/rear/rear/commit/cc3bc3793602ef44cd93a452b60be16cee65446c
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2021-12-07 (Tue, 07 Dec 2021)

  Changed paths:
    M usr/share/rear/conf/default.conf
    M usr/share/rear/layout/recreate/default/120_confirm_wipedisk_disks.sh
    M usr/share/rear/layout/recreate/default/150_wipe_disks.sh

  Log Message:
  -----------
  Merge pull request #2721 from rear/jsmeix-improve-wipe-disks

Improved wiping disks:
In layout/recreate/default/120_confirm_wipedisk_disks.sh
skip disks that do not exist on the bare hardware in the recovery system
cf. https://github.com/rear/rear/issues/2715
and exclude disks that are write-protected
cf. https://github.com/rear/rear/pull/2703#issuecomment-979928423
and show in any case a user confirmation dialog for the disks that will be wiped.
In layout/recreate/default/150_wipe_disks.sh do no longer
open (and close) LUKS volumes because encrypted volumes
contain meaningless data unless opened and unencrypted so there is no need
to wipe anything inside an encrypted LUKS container, cf. "Regarding LUKS"
in https://github.com/rear/rear/pull/2514#issuecomment-743483945


Compare: https://github.com/rear/rear/compare/13755a457c15...cc3bc3793602


More information about the rear-devel mailing list