[rear-devel] [rear/rear] 8b215f: Fix including of multipath disks in backup

Johannes Meixner noreply at github.com
Fri Oct 18 13:39:49 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 8b215f8733e76804175f76806b3b0fbd3d74fef9
      https://github.com/rear/rear/commit/8b215f8733e76804175f76806b3b0fbd3d74fef9
  Author: Petr Pavlu <petr.pavlu at suse.com>
  Date:   2019-09-23 (Mon, 23 Sep 2019)

  Changed paths:
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Fix including of multipath disks in backup

The AUTOEXCLUDE_DISKS logic (320_autoexclude.sh) traverses filesystems
and tries to determine the associated underlying disks that should be
kept. When having a filesystem fs:/A that is present on a multipath
device MP and the root filesystem fs:/ that is present on a normal disk
D, the code first established that fs:/A depends on fs:/ resulting in
marking D as used and then short-circuited processing of multipath
devices. This resulted in MP not being considered as a used device and
removed from the backup.

The patch fixes this problem by removing the short-circuit logic in
find_disk_and_multipath() so multipath devices get processed too (unless
AUTOEXCLUDE_MULTIPATH is true).

Fixes #2236.


  Commit: 84d74a3646c99f3a78a9b20ac57c5935af6c4888
      https://github.com/rear/rear/commit/84d74a3646c99f3a78a9b20ac57c5935af6c4888
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2019-10-18 (Fri, 18 Oct 2019)

  Changed paths:
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Merge pull request #2237 from petrpavlu/multipath-exclude

Fix including of multipath disks in backup:
The AUTOEXCLUDE_DISKS logic traverses filesystems and tries
to determine the associated underlying disks that should be kept.
When having a filesystem fs:/A that is present on a multipath
device MP and the root filesystem fs:/ that is present on a normal
disk D, the code first established that fs:/A depends on fs:/
resulting in marking D as used and then short-circuited processing
of multipath devices. This resulted in MP not being considered
as a used device and removed from the backup.
The problem is fxed by removing the short-circuit logic in
find_disk_and_multipath() so multipath devices get processed
too (unless AUTOEXCLUDE_MULTIPATH is true).


Compare: https://github.com/rear/rear/compare/0584c3287aad...84d74a3646c9


More information about the rear-devel mailing list