[rear-devel] [rear/rear] 793d09: Improve handling of partition label type for multi...

Johannes Meixner noreply at github.com
Fri Oct 18 12:06:46 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 793d096a61b97334a2e9c3ac62077c7926ef41cf
      https://github.com/rear/rear/commit/793d096a61b97334a2e9c3ac62077c7926ef41cf
  Author: Petr Pavlu <petr.pavlu at suse.com>
  Date:   2019-09-23 (Mon, 23 Sep 2019)

  Changed paths:
    M doc/user-guide/06-layout-configuration.adoc
    M usr/share/rear/layout/prepare/GNU/Linux/210_load_multipath.sh
    M usr/share/rear/layout/prepare/default/520_exclude_components.sh
    M usr/share/rear/layout/save/GNU/Linux/280_multipath_layout.sh
    M usr/share/rear/layout/save/default/320_autoexclude.sh
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Improve handling of partition label type for multipath disks

When recording information about a multipath disk, ReaR did not store
information about its partition label type (280_multipath_layout.sh).
The recovery code create_multipath() (210_load_multipath.sh) ->
create_partitions() (100_include_partition_code.sh) then tried to
automatically detect the label type using a heuristic that depends on
GPT partition names. The logic would incorrectly detect the device as
having the MBR label type instead of GPT if one of the partition names
was exactly "primary", "extended" or "logical".

The patch fixes the problem by explicitly storing the partition label
type for multipath devices as is already done for normal disks. The
restore logic is accordingly updated to utilize this information.

Fixes #2234.


  Commit: 0584c3287aade755bc2f4e4a70fffc8467b59eb8
      https://github.com/rear/rear/commit/0584c3287aade755bc2f4e4a70fffc8467b59eb8
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2019-10-18 (Fri, 18 Oct 2019)

  Changed paths:
    M doc/user-guide/06-layout-configuration.adoc
    M usr/share/rear/layout/prepare/GNU/Linux/210_load_multipath.sh
    M usr/share/rear/layout/prepare/default/520_exclude_components.sh
    M usr/share/rear/layout/save/GNU/Linux/280_multipath_layout.sh
    M usr/share/rear/layout/save/default/320_autoexclude.sh
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Merge pull request #2235 from petrpavlu/multipath-gpt

Improve handling of partition label type for multipath disks:
When recording information about a multipath disk,
ReaR did not store information about its partition label type
in the 'multipath' entry in disklayout.conf.
The recovery code tried to automatically detect the label type
using a heuristic that depends on GPT partition names.
The logic would incorrectly detect the device as having the
MBR label type instead of GPT if one of the partition names
was exactly "primary", "extended" or "logical".
The problem is solved by explicitly storing the partition label type
for multipath devices (same as is already done for normal disks)
so that the syntax of the 'multipath' entries in disklayout.conf 
is changed and that new syntax is now documented in
doc/user-guide/06-layout-configuration.adoc
The recovery code is accordingly updated to utilize this information.
See https://github.com/rear/rear/issues/2234


Compare: https://github.com/rear/rear/compare/0f9679734b5c...0584c3287aad


More information about the rear-devel mailing list