[rear-devel] [rear/rear] 07722d: Error out in case of insufficient LVM tools (issue...

Johannes Meixner noreply at github.com
Fri Dec 13 13:48:09 CET 2019


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 07722d05fbed92a691d99d6582d766e6a446ed86
      https://github.com/rear/rear/commit/07722d05fbed92a691d99d6582d766e6a446ed86
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Error out in case of insufficient LVM tools (issue 2259)


  Commit: 85e89691050e2a884f9b9d5f13ec79ea9adb0e9c
      https://github.com/rear/rear/commit/85e89691050e2a884f9b9d5f13ec79ea9adb0e9c
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M usr/share/rear/layout/save/default/950_verify_disklayout_file.sh

  Log Message:
  -----------
  Initial attempt to verify LVM entries in disklayout.conf


  Commit: fe0fea26008503f10db756f950b79a77255e0be7
      https://github.com/rear/rear/commit/fe0fea26008503f10db756f950b79a77255e0be7
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-03 (Tue, 03 Dec 2019)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Completely overhauled layout/save/GNU/Linux/220_lvm_layout.sh


  Commit: b62fa0beb4503fe0a3c55ea0d0c2a2a803227fb1
      https://github.com/rear/rear/commit/b62fa0beb4503fe0a3c55ea0d0c2a2a803227fb1
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Explanatory comment why we use pipes here instead of process substitution


  Commit: a90c9b565a5f64498f623160bd74cb69f705053a
      https://github.com/rear/rear/commit/a90c9b565a5f64498f623160bd74cb69f705053a
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Improved the explanatory comment why we use pipes here instead of process substitution


  Commit: c02077343e3bdff408e22eb1bb5e571aed874349
      https://github.com/rear/rear/commit/c02077343e3bdff408e22eb1bb5e571aed874349
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-10 (Tue, 10 Dec 2019)

  Changed paths:
    M doc/user-guide/06-layout-configuration.adoc
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  Check that the required positional parameters in the lvm... entries in disklayout.conf are non-empty and list in 06-layout-configuration.adoc in the disk layout file syntax section the same syntax for the lvm... entries as the headers of the lvm... entries in disklayout.conf are


  Commit: 3bb3f62ebd49964f47117ce585ded5366ff63fe1
      https://github.com/rear/rear/commit/3bb3f62ebd49964f47117ce585ded5366ff63fe1
  Author: Johannes Meixner <jsmeix at suse.de>
  Date:   2019-12-11 (Wed, 11 Dec 2019)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh

  Log Message:
  -----------
  More exact error messages when lvm... entries in disklayout.conf are invalid


  Commit: 27e2f0c1041fd1b802749d6c66ec60936d762e0f
      https://github.com/rear/rear/commit/27e2f0c1041fd1b802749d6c66ec60936d762e0f
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2019-12-13 (Fri, 13 Dec 2019)

  Changed paths:
    M doc/user-guide/06-layout-configuration.adoc
    M usr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh
    M usr/share/rear/layout/save/default/950_verify_disklayout_file.sh

  Log Message:
  -----------
  Merge pull request #2291 from jsmeix/error_out_in_case_of_insufficient_LVM_tools_issue2259

Error out during "rear mkrescue" in case of insufficient LVM tools:
Overhauled layout/save/GNU/Linux/220_lvm_layout.sh
where now the exit code of the "lvm ..." calls are checked
and it errors out if one fails in particular to avoid that
entries in disklayout.conf are missing or broken
when too old LVM tools are used that do not support
the needed options of those "lvm ..." calls
(cf. https://github.com/rear/rear/issues/2259).
Also in layout/save/default/950_verify_disklayout_file.sh
a simple test was added to verify that the 'lvm...' entries
in disklayout.conf look syntactically correct.
Furthermore in 06-layout-configuration.adoc in the
"Disk layout file syntax" section the exact same syntax
for the "lvm..." entries is now listed as the headers
of the "lvm..." entries in disklayout.conf are.


Compare: https://github.com/rear/rear/compare/e18957ebfbc9...27e2f0c1041f


More information about the rear-devel mailing list