[rear-devel] [rear/rear] ec3c2d: Fix for 'error:unrecognized number' when booting I...

[Johannes Meixner]

  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: ec3c2d1e7818f17233216d1a8e6a70e592d5a290
      https://github.com/rear/rear/commit/ec3c2d1e7818f17233216d1a8e6a70e592d5a290
  Author: Renaud Métrich <rmetrich at redhat.com>
  Date:   2018-11-23 (Fri, 23 Nov 2018)

  Changed paths:
    M usr/share/rear/output/ISO/Linux-ppc64/310_create_grub2.sh
    M usr/share/rear/output/ISO/Linux-ppc64le/300_create_grub2.sh

  Log Message:
  -----------
  Fix for 'error:unrecognized number' when booting ISO on PPC

Issue is caused by incorrect, according to PAPR specification,
bootinfo entity parsing code in grub2.

In PAPR spec "B.4.1.6.1 Bootinfo Entities" partition and path
separator (,) is optional and if not present bootinfo may be
treated as directory and filename components unless it begins
with number:

  &device;:[&partition;][,]&directory;&filename;

If (,) is missing and directory begins with a hexadecimal number
GRUB2 treats this as partition number immediately followed by a
directory/filename.

Note that with (,) present in bootpath issue isn't in the case
as GRUB2 returns empty string for GRUB_PARSE_PARTITIONS. This
effectively meaning that GRUB2 code requires (,) as mandatory.

This is a GRUB2 bug, but until it is fixed, we can make the message disappear by specifying a comma in bootinfo.txt.

Signed-off-by: Renaud Métrich <rmetrich at redhat.com>


  Commit: d1435fb325a6a108d80ddcd2b3f6997bbc6d5c93
      https://github.com/rear/rear/commit/d1435fb325a6a108d80ddcd2b3f6997bbc6d5c93
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2018-12-06 (Thu, 06 Dec 2018)

  Changed paths:
    M usr/share/rear/output/ISO/Linux-ppc64/310_create_grub2.sh
    M usr/share/rear/output/ISO/Linux-ppc64le/300_create_grub2.sh

  Log Message:
  -----------
  Merge pull request #1978 from rmetrich/PPC

Fixed 'error:unrecognized number' when booting ISO on PPC.
That error was caused by incorrect, according to PAPR specification,
bootinfo entity parsing code in GRUB. The fix adds the (normally optional)
partition and path separator comma ',' in bootpath in any case because
current GRUB2 code requires that (normally optional) comma in any case
so that ReaR needs to provide that comma in bootinfo.txt in any case.


Compare: https://github.com/rear/rear/compare/6ec9075aabb8...d1435fb325a6
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.