[rear-devel] [rear/rear] 209528: #1884 - Partition information recorded is unexpect...

Johannes Meixner jsmeix at suse.com
Tue Aug 7 13:21:56 CEST 2018


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 2095280098571799f2b01357520a00388171f211
      https://github.com/rear/rear/commit/2095280098571799f2b01357520a00388171f211
  Author: Renaud Métrich <rmetrich at redhat.com>
  Date:   2018-08-01 (Wed, 01 Aug 2018)

  Changed paths:
    M usr/share/rear/conf/GNU/Linux.conf
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  #1884 - Partition information recorded is unexpected when disk has 4K block size

- Use 'blockdev' to retrieve the size of the disk and block size (unused)
- Compute partition start using 512 bytes blocks (this is hardcoded in the Linux kernel)


  Commit: 82556801cb8d3b42ee0e3f20f66dfe3db53e6793
      https://github.com/rear/rear/commit/82556801cb8d3b42ee0e3f20f66dfe3db53e6793
  Author: Renaud Métrich <rmetrich at redhat.com>
  Date:   2018-08-01 (Wed, 01 Aug 2018)

  Changed paths:
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  - Force blocksize to 512 for 'legacy' get_disk_size() code
- Handle 'blockdev' errors properly (bail out, 'blockdev' must just work)


  Commit: b4fd97fd47d8c15ca1383dd911ec018780dce77b
      https://github.com/rear/rear/commit/b4fd97fd47d8c15ca1383dd911ec018780dce77b
  Author: Renaud Métrich <rmetrich at redhat.com>
  Date:   2018-08-06 (Mon, 06 Aug 2018)

  Changed paths:
    M usr/share/rear/conf/GNU/Linux.conf
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Fixed blockdev issue when reading empty DVD tray + added 'lsblk'


  Commit: 6e390a0b269ce471997d6d6713343560e3e86898
      https://github.com/rear/rear/commit/6e390a0b269ce471997d6d6713343560e3e86898
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2018-08-07 (Tue, 07 Aug 2018)

  Changed paths:
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Update layout-functions.sh

Added explanatory comments to the code so that at any time later
it is still clear from plain reading the code why the code is as it is
even for users who cannot compare or reproduce
how the code behaves on different systems
cf. https://github.com/rear/rear/wiki/Coding-Style


  Commit: 6149d2d48798c12d11014607f404916fe485e0de
      https://github.com/rear/rear/commit/6149d2d48798c12d11014607f404916fe485e0de
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2018-08-07 (Tue, 07 Aug 2018)

  Changed paths:
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Update layout-functions.sh

Typo fix in comment 'the the' => 'the'


  Commit: da6e5b8418eecd59bdc172a59341b25d6c1acf47
      https://github.com/rear/rear/commit/da6e5b8418eecd59bdc172a59341b25d6c1acf47
  Author: Johannes Meixner <jsmeix at suse.com>
  Date:   2018-08-07 (Tue, 07 Aug 2018)

  Changed paths:
    M usr/share/rear/conf/GNU/Linux.conf
    M usr/share/rear/lib/layout-functions.sh

  Log Message:
  -----------
  Merge pull request #1885 from rmetrich/4K

Fixed and enhanced the get_disk_size and get_block_size functions
in lib/layout-functions.sh so that now by default
blockdev is used (if exists) to retrieve the size of the disk and its block size and
compute partition start using 512 bytes blocks (this is hardcoded in the Linux kernel)
to fix wrong partition information when a disk has 4K block size, see
https://github.com/rear/rear/issues/1884
Additionally together with blockdev also lsblk gets included in the recovery system
(if it exists on the original system) so that now lsblk can be used by default to
determine disk values and the block device structure in the recovery system.


Compare: https://github.com/rear/rear/compare/be14c9ad1280...da6e5b8418ee
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the rear-devel mailing list