[rear-devel] [rear/rear] 7f0339: Ignoring block device which are part of a multipat...

Gratien D'haese gratien.dhaese at gmail.com
Wed Jun 1 11:52:36 CEST 2016


  Branch: refs/heads/master
  Home:   https://github.com/rear/rear
  Commit: 7f033919bf47948073362afb08f0762f4f44574d
      https://github.com/rear/rear/commit/7f033919bf47948073362afb08f0762f4f44574d
  Author: Sebastien Chabrolles <s.chabrolles at fr.ibm.com>
  Date:   2016-05-29 (Sun, 29 May 2016)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/20_partition_layout.sh

  Log Message:
  -----------
  Ignoring block device which are part of a multipath device.

20_partition_layout.sh gets partition size from /sys/block filesystem for every hdX or sdX device. But if the block device is a path of a multipath device, partition and size information does not exist which stop the script with the following message:

"ERROR: BUG BUG BUG!  Could not determine size of disk sdb/sdb2, please file a bug.
=== Issue report === Please report this unexpected issue at: https://github.com/rear/rear/issues Also include the relevant bits from /var/log/rear/rear-XXXXXXXX.log.lockless"

To avoid this situation, we test if the sdX or hdX is part of a multipath device. If yes, we ignore it (real multipath device dm-X will be treated further by multipath scripts).


  Commit: 8af5589e68355899f5fed0a69c4c0425d4ff3903
      https://github.com/rear/rear/commit/8af5589e68355899f5fed0a69c4c0425d4ff3903
  Author: Sebastien Chabrolles <s.chabrolles at fr.ibm.com>
  Date:   2016-05-30 (Mon, 30 May 2016)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/20_partition_layout.sh

  Log Message:
  -----------
  Add a is_multipath_path function (thanks to schlomo)
* Avoid to use multipath command if this one is not present
* Improve code readibility


  Commit: 9043d320ff765d5a449fe3b223396a4401d4b234
      https://github.com/rear/rear/commit/9043d320ff765d5a449fe3b223396a4401d4b234
  Author: Sebastien Chabrolles <s.chabrolles at fr.ibm.com>
  Date:   2016-05-30 (Mon, 30 May 2016)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/20_partition_layout.sh

  Log Message:
  -----------
   use is_multipath_path $blockd instead of /dev/$blockd


  Commit: a5261ea2d3898998e983db03587998e28674ab3f
      https://github.com/rear/rear/commit/a5261ea2d3898998e983db03587998e28674ab3f
  Author: Gratien D'haese <gratien.dhaese at gmail.com>
  Date:   2016-06-01 (Wed, 01 Jun 2016)

  Changed paths:
    M usr/share/rear/layout/save/GNU/Linux/20_partition_layout.sh

  Log Message:
  -----------
  Merge pull request #853 from schabrolles/multipath_BUG

Ignoring block device which are part of a multipath device.


Compare: https://github.com/rear/rear/compare/5a20ac1f1256...a5261ea2d389


More information about the rear-devel mailing list